Add LLDP configuration support #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements EmitLLDP D-bus property to support configuration of enable/disable LLDP of each ethernet interface. Tested by: Set EmitLLDP D-bus property on xyz.openbmc_project.Network.EthernetInterface Change-Id: I4ebedff9d3f914219f2f84c861fdee126584a94b Signed-off-by: Ravi Teja <[email protected]>
|
upstream commit https://gerrit.openbmc.org/c/openbmc/phosphor-networkd/+/76368 |
abhilashraju
approved these changes
Jan 7, 2025
| @@ -529,6 +530,21 @@ void Manager::handleAdminState(std::string_view state, unsigned ifidx) | |||
| } | |||
| } | |||
|
|
|||
| void Manager::loadDefaultLLDPConfig() | |||
There was a problem hiding this comment.
the name is loadDefaultLLDPConfig or storeDefaultLLDPConfig?
There was a problem hiding this comment.
basically its updating lldp config file with default config during network daemon start
asmithakarun
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements EmitLLDP D-bus property to support configuration of enable/disable LLDP of each ethernet interface.
Tested by:
Set EmitLLDP D-bus property on
xyz.openbmc_project.Network.EthernetInterface
Change-Id: I4ebedff9d3f914219f2f84c861fdee126584a94b